Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC456 refactoring the code to add new calculation algo #5

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Conversation

dmitriy-helius
Copy link
Collaborator

@dmitriy-helius dmitriy-helius commented Aug 19, 2024

Overview

  • Adding test worker to run tests in github
  • Adding stricter json parser validation to make sure clients will receive an error if incorrect property or incorrect value is passed
  • Adding new calculation for priority fee
  • Adding the collector to calculate both algos out of band and recording diffs

Testing

  • Testing locally with the unit tests
  • Wrote number of new tests to test both calculations
  • Tested by connecting to grpc / rpc and sending some requests

src/rpc_server.rs Outdated Show resolved Hide resolved
src/rpc_server.rs Outdated Show resolved Hide resolved
src/rpc_server.rs Outdated Show resolved Hide resolved
@vovkman
Copy link
Contributor

vovkman commented Aug 22, 2024

I see annotations coming up in the PR comments, is there a better way to make those actionable?

@dmitriy-helius
Copy link
Collaborator Author

Hm, not sure. In past I saw integrations with ticketing systems for PR comments but honestly I usually just keep notes for my self and click resolve when done

@vovkman
Copy link
Contributor

vovkman commented Aug 22, 2024

Hm, not sure. In past I saw integrations with ticketing systems for PR comments but honestly I usually just keep notes for my self and click resolve when done

Okay I guess lets just try it out

@dmitriy-helius dmitriy-helius force-pushed the 456 branch 3 times, most recently from 9dc2374 to 690b757 Compare August 22, 2024 15:21
src/rpc_server.rs Outdated Show resolved Hide resolved
src/priority_fee.rs Outdated Show resolved Hide resolved
@dmitriy-helius dmitriy-helius changed the title RPC456 adding support to run tests in github RPC456 refactoring the code to add new calculation algo Aug 23, 2024
src/priority_fee.rs Outdated Show resolved Hide resolved
src/priority_fee.rs Outdated Show resolved Hide resolved
src/priority_fee.rs Outdated Show resolved Hide resolved
src/rpc_server.rs Outdated Show resolved Hide resolved
…counter to see how many json failures do we have
@dmitriy-helius dmitriy-helius merged commit 990fa4d into main Aug 27, 2024
2 checks passed
@dmitriy-helius dmitriy-helius deleted the 456 branch August 27, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants